Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split CI configuration across multiple files #316

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Conversation

justsmth
Copy link
Contributor

Issues:

N/A

Description of changes:

Split CI configuration across multiple files.

Call-outs:

N/A

Testing:

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner January 23, 2024 17:41
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c5bb144) 95.91% compared to head (09a6e4c) 95.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files          60       60           
  Lines        8522     8522           
=======================================
  Hits         8174     8174           
  Misses        348      348           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WillChilds-Klein
Copy link

were any changes made to the contents, or is this strictly copy/paste from one file to a few others?

also, should some of these GHA jobs be required to pass before PRs can be merged?

@justsmth
Copy link
Contributor Author

were any changes made to the contents, or is this strictly copy/paste from one file to a few others?

Yeah, the only change to the jobs is that I added a "fips" run for the coverage job. Otherwise, no changes to the jobs.

also, should some of these GHA jobs be required to pass before PRs can be merged?

I agree. After this gets merged, we need to reconfigure the "required" CI jobs. (The GitHub UI for managing these has been painful to use.)

@justsmth justsmth merged commit 9b66263 into aws:main Jan 23, 2024
104 of 111 checks passed
@justsmth justsmth deleted the ci-split branch January 23, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants