-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No CMake required for non-FIPS #317
Conversation
b73db11
to
8192138
Compare
5abfe93
to
936ea0c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 60 60
Lines 7865 7865
=======================================
Hits 7537 7537
Misses 328 328 ☔ View full report in Codecov by Sentry. |
93459f5
to
87b1d43
Compare
568ccb4
to
455e12e
Compare
455e12e
to
254d5c8
Compare
1c0e78d
to
01bb501
Compare
One thing to note that we need to replicate (and maintain) the build-time checks here: https://github.com/aws/aws-lc/blob/37708f52446ee727ebeea6beaba75baf0588593b/CMakeLists.txt#L426-L430 |
3c03987
to
9baf363
Compare
What do you refer to when you say FIPS? Federal Information Processing Standards? Apologize for being silly, not familiar with the abbreviation. |
Yeah, "FIPS" stands for "Federal Information Processing Standards". We perform a special build process for AWS-LC when the "fips" feature is enabled. There is more information and links in this blog post about it: https://aws.amazon.com/blogs/security/aws-lc-is-now-fips-140-3-certified/ |
@@ -54,6 +54,7 @@ bindgen = ["dep:bindgen"] # Generate the bindings on the targetted platform as a | |||
cmake = "0.1.48" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does cmake have to be a part of build-dependencies?
Issues:
Addresses Issues:
Description of changes:
Call-outs:
i686-unknown-linux-gnu
,x86_64-unknown-linux-gnu
,aarch64-unknown-linux-gnu
,x86_64-unknown-linux-musl
,aarch64-unknown-linux-musl
,x86_64-apple-darwin
,aarch64-apple-darwin
AWS_LC_SYS_CMAKE_BUILDER
environment variable can be used to force the build to use, or not use, CMake.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.