Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve how vcvarsall is located #327

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Improve how vcvarsall is located #327

merged 4 commits into from
Jan 29, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Jan 29, 2024 •
edited
Loading

Issues:

N/A

Description of changes:

  • For the Windows/FIPS build, add fallback logic for locating vcvarsall.bat when vswhere.exe fails.
  • Increase verbosity of failures.

Call-outs:

N/A

Testing:

  • I'm still not sure of the root cause for the build failure seen here. However, this change should provide more logging to diagnose the issue.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner January 29, 2024 16:29
@justsmth justsmth mentioned this pull request Jan 29, 2024
Merged
skmcgrail
skmcgrail previously approved these changes Jan 29, 2024
View reviewed changes
@justsmth justsmth merged commit fcab5fd into aws:main Jan 29, 2024
131 of 134 checks passed
@justsmth justsmth deleted the find-vcvarsall branch January 29, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillChilds-Klein WillChilds-Klein WillChilds-Klein approved these changes

@skmcgrail skmcgrail skmcgrail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justsmth @skmcgrail @WillChilds-Klein