Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MSRV CI #336

Merged
merged 6 commits into from
Feb 14, 2024
Merged

Improve MSRV CI #336

merged 6 commits into from
Feb 14, 2024

Conversation

justsmth
Copy link
Contributor

Issues:

#334

Description of changes:

  • Improve CI for MSRV
  • Pin dev-dependencies to match MSRV
  • Remove a few unnecessary unsafe blocks.

Call-outs:

N/A

Testing:

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner January 31, 2024 19:05
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc9f7ee) 95.82% compared to head (18127eb) 95.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files          62       62           
  Lines        8025     8025           
=======================================
  Hits         7690     7690           
  Misses        335      335           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth requested a review from nebeid February 13, 2024 18:29
@darylmartin100 darylmartin100 requested review from samuel40791765 and removed request for nebeid February 13, 2024 19:16
@justsmth justsmth merged commit d47ed6f into aws:main Feb 14, 2024
142 of 145 checks passed
@justsmth justsmth deleted the improve-msrv-ci branch February 14, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants