CI script to setup/test aarch64-apple-ios-sim #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 60 60
Lines 7865 7865
=======================================
Hits 7537 7537
Misses 328 328 ☔ View full report in Codecov by Sentry. |
justsmth
force-pushed
the
ios-sim-DYLD_ROOT_PATH
branch
2 times, most recently
from
c93df77
to
de02e5c
Compare
justsmth
force-pushed
the
ios-sim-DYLD_ROOT_PATH
branch
2 times, most recently
from
5f6da63
to
c99a5b3
Compare
justsmth
force-pushed
the
ios-sim-DYLD_ROOT_PATH
branch
2 times, most recently
from
c1ed9c4
to
843dd69
Compare
justsmth
changed the title
aarch64-apple-ios-sim until we find alternative
samuel40791765
previously approved these changes
Feb 21, 2024
justinwsmith
force-pushed
the
ios-sim-DYLD_ROOT_PATH
branch
from
843dd69
to
977060b
Compare
justinwsmith
force-pushed
the
ios-sim-DYLD_ROOT_PATH
branch
5 times, most recently
from
85b9358
to
9834b61
Compare
justinwsmith
changed the title
aarch64-apple-ios-sim until we find alternative
justinwsmith
changed the title
justinwsmith
force-pushed
the
ios-sim-DYLD_ROOT_PATH
branch
from
9834b61
to
18876ac
Compare
justinwsmith
force-pushed
the
ios-sim-DYLD_ROOT_PATH
branch
from
18876ac
to
e340f53
Compare
skmcgrail
reviewed
Feb 22, 2024
skmcgrail
approved these changes
Feb 23, 2024
samuel40791765
approved these changes
Feb 23, 2024
| fi | ||
| done | ||
|
|
||
| if [[ -z ${IMAGE_PATH} ]]; then |
There was a problem hiding this comment.
Suggested change
| if [[ -z ${IMAGE_PATH} ]]; then | |
| if [[ -z "${IMAGE_PATH}" ]]; then |
consistency nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.