Update aws-lc-rs to v1.6.4 #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #380 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 60 60
Lines 7865 7865
=======================================
Hits 7537 7537
Misses 328 328 ☔ View full report in Codecov by Sentry. |
skmcgrail
approved these changes
Apr 2, 2024
skmcgrail
reviewed
Apr 2, 2024
| # this crate re-exports whatever sys crate that was selected | ||
| links = "aws_lc_rs_1_6_3_sys" | ||
| links = "aws_lc_rs_1_6_4_sys" |
There was a problem hiding this comment.
sys crate version numbers recorded in the dependencies should be updated too? Just so that it doesn't reference the yanked version?
There was a problem hiding this comment.
It should automatically pick up the latest patch version regardless. I'm fine either way.
There was a problem hiding this comment.
Just looks a little weird to release a version that still refers to the yanked sys crate version. Just removes one less variable to whether the right behavior will occur or not.
smittals2
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.