Support target x86_64-apple-ios #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 60 60
Lines 7865 7865
=======================================
Hits 7537 7537
Misses 328 328 ☔ View full report in Codecov by Sentry. |
skmcgrail
approved these changes
Apr 5, 2024
samuel40791765
approved these changes
Apr 9, 2024
| target: aarch64-apple-ios-sim | ||
| - name: Set Rust toolchain override | ||
| run: rustup override set ${{ steps.toolchain.outputs.name }} | ||
| - name: Install bash | ||
| run: brew install bash | ||
| - name: iOS Simulator Runner | ||
| run: ./scripts/ci/ios-simulator-runner.sh |
There was a problem hiding this comment.
NP: Might be worth renaming this file to make it clear that it only tests the iOS aarch64 simulator. Just double checking, cargo test --features bindgen,unstable --target x86_64-apple-ios isn't runnable on an M1 machine right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #373
Description of changes:
x86_64-apple-ios.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.