Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for User Guide #400

Merged
merged 4 commits into from
May 2, 2024
Merged

Updates for User Guide #400

merged 4 commits into from
May 2, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Apr 18, 2024

Changes

  • Updated documentation on platforms and the requirements for each.
  • Improved build failure error messages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth changed the title [DRAFT] Updates for User Guide Updates for User Guide Apr 26, 2024
@justsmth justsmth marked this pull request as ready for review April 26, 2024 15:14
@justsmth justsmth requested a review from a team as a code owner April 26, 2024 15:14
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (3c9e90b) to head (b6a9934).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   95.80%   95.80%           
=======================================
  Files          61       61           
  Lines        8143     8143           
=======================================
  Hits         7801     7801           
  Misses        342      342           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth requested a review from skmcgrail April 26, 2024 17:29
skmcgrail
skmcgrail previously approved these changes Apr 29, 2024
skmcgrail
skmcgrail previously approved these changes May 2, 2024
aws-lc-fips-sys/builder/cmake_builder.rs Outdated Show resolved Hide resolved
aws-lc-sys/builder/cmake_builder.rs Outdated Show resolved Hide resolved
book/src/requirements/apple.md Outdated Show resolved Hide resolved
book/src/requirements/apple.md Outdated Show resolved Hide resolved
skmcgrail
skmcgrail previously approved these changes May 2, 2024
@justsmth justsmth merged commit beaf5e2 into aws:main May 2, 2024
178 of 184 checks passed
@justsmth justsmth deleted the user-guide-update branch May 2, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants