Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support build for aarch64-pc-windows-msvc #406

Merged
merged 1 commit into from
May 22, 2024

Conversation

justinwsmith
Copy link
Contributor

@justinwsmith justinwsmith commented Apr 23, 2024

Issues:

Resolves:

Description of changes:

  • Fixes build for aarch64-pc-windows-msvc . It requires that clang-cl and ninja be installed.

Testing:

  • Verified locally that tests pass on a Windows/ARM64 host.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justinwsmith justinwsmith force-pushed the aarch64-pc-windows-msvc branch 5 times, most recently from cf93498 to 93b74ef Compare April 23, 2024 21:46
@justinwsmith justinwsmith force-pushed the aarch64-pc-windows-msvc branch 2 times, most recently from ed88078 to 14194fc Compare May 17, 2024 21:07
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.66%. Comparing base (c358484) to head (83b24bd).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   95.80%   92.66%   -3.14%     
==========================================
  Files          61       61              
  Lines        8143     8176      +33     
  Branches        0     8176    +8176     
==========================================
- Hits         7801     7576     -225     
- Misses        342      358      +16     
- Partials        0      242     +242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinwsmith justinwsmith changed the title [DRAFT] Support build for aarch64-pc-windows-msvc Support build for aarch64-pc-windows-msvc May 17, 2024
@justinwsmith justinwsmith marked this pull request as ready for review May 17, 2024 21:23
@justinwsmith justinwsmith requested a review from a team as a code owner May 17, 2024 21:23
@justsmth justsmth merged commit 23b3dc8 into aws:main May 22, 2024
179 of 186 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants