Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSA 8192 (slow) tests only for release build #407

Merged
merged 1 commit into from
May 8, 2024

Conversation

justsmth
Copy link
Contributor

Description of changes:

  • Avoid running slow RSA8192 tests on debug builds.

Call-outs:

This is similar to what we do for a couple of slow digest tests:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner April 24, 2024 14:24
@skmcgrail skmcgrail requested a review from samuel40791765 May 7, 2024 17:44
@justsmth justsmth force-pushed the rsa-8192-release-tests branch from 5f7559e to aab72ba Compare May 7, 2024 19:59
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.66%. Comparing base (c358484) to head (aab72ba).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   95.80%   92.66%   -3.14%     
==========================================
  Files          61       61              
  Lines        8143     8176      +33     
  Branches        0     8176    +8176     
==========================================
- Hits         7801     7576     -225     
- Misses        342      358      +16     
- Partials        0      242     +242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth merged commit 00a2ad3 into aws:main May 8, 2024
184 checks passed
@justsmth justsmth deleted the rsa-8192-release-tests branch May 8, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants