Streaming API for CBC and CTR cipher modes #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
force-pushed
the
stream-cipher
branch
2 times, most recently
from
0159744 to
bfc9171
Compare
justsmth
force-pushed
the
stream-cipher
branch
6 times, most recently
from
525aa5b to
88e3b68
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
==========================================
- Coverage 95.80% 92.83% -2.97%
==========================================
Files 61 62 +1
Lines 8143 8626 +483
Branches 0 8626 +8626
==========================================
+ Hits 7801 8008 +207
- Misses 342 362 +20
- Partials 0 256 +256 ☔ View full report in Codecov by Sentry. |
justsmth
force-pushed
the
stream-cipher
branch
5 times, most recently
from
63c1f6e to
c30f142
Compare
camshaft
reviewed
May 14, 2024
justsmth
force-pushed
the
stream-cipher
branch
6 times, most recently
from
f6e182c to
05e253e
Compare
justsmth
changed the title
|
Some CI jobs are failing due to the the "nightly" Rust compiler panicking. The issue is reported here: rust-lang/rust#125474 |
skmcgrail
reviewed
Jun 4, 2024
justsmth
force-pushed
the
stream-cipher
branch
4 times, most recently
from
ee7d6db to
18f67e2
Compare
skmcgrail
reviewed
Jun 11, 2024
skmcgrail
approved these changes
Jun 19, 2024
WillChilds-Klein
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Description
StreamingEncryptionKeyandStreamingDecryptionKeysupporting operations with AES128 and AES256 in CTR and CBC (w/ PKCS7 padding) modesupdateandfinalfunctions return aBufferUpdatestruct indicating where the provided output buffer was modified.ciphermodule documentation.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.