Cleanup CI and build configs #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
force-pushed
the
build-ci-cleanup
branch
3 times, most recently
from
bf2f826
to
2426bd4
Compare
justsmth
changed the title
skmcgrail
approved these changes
May 7, 2024
WillChilds-Klein
approved these changes
May 7, 2024
Comment on lines
+162
to
+167
| expect_iterated_x25519( | ||
| "7c3911e0ab2586fd864497297e575e6f3bc601c0883c30df5f4dd2d24f665424", | ||
| 10_000..1_000_000, | ||
| &mut k, | ||
| &mut u, | ||
| ); |
There was a problem hiding this comment.
why disable this test? is it too slow?
There was a problem hiding this comment.
Yeah, really slow. This was never executing anyways due to being conditioned on a non-existent feature. However, I'm not opposed too putting a guard around such tests so that they can still execute, but only when we're prepared to wait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
actions-rsGitHub action.unexpected_cfgs. We can't properly handle these until we're at MSRV 1.77.cfgvalues.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.