Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-compile using bindgen-cli #429

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented May 28, 2024

Issues:

Resolves #428

Description of changes:

  • Install/Use bindgen-cli inside container when cross-compiling with cross-rs.
  • Added target armv7-unknown-linux-gnueabihf

Call-out

  • I changed the order of the CI targets to be sorted by name.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth changed the title [DRAFT] Cross-compile using bindgen-cli Cross-compile using bindgen-cli May 29, 2024
@justsmth justsmth marked this pull request as ready for review May 29, 2024 13:02
@justsmth justsmth requested a review from a team as a code owner May 29, 2024 13:02
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.67%. Comparing base (c358484) to head (d730f3d).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
- Coverage   95.80%   92.67%   -3.13%     
==========================================
  Files          61       61              
  Lines        8143     8174      +31     
  Branches        0     8174    +8174     
==========================================
- Hits         7801     7575     -226     
- Misses        342      357      +15     
- Partials        0      242     +242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuel40791765 samuel40791765 self-requested a review June 4, 2024 17:29
@justsmth justsmth merged commit 7607cd1 into aws:main Jun 4, 2024
187 checks passed
@justsmth justsmth deleted the cross-bindgen-cli branch June 4, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x86_64-pc-windows-gnu build failed
4 participants