Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support openharmony platform #434

Merged
merged 4 commits into from
Jun 11, 2024
Merged

feat: support openharmony platform #434

merged 4 commits into from
Jun 11, 2024

Conversation

richerfu
Copy link
Contributor

@richerfu richerfu commented Jun 5, 2024

Issues:

Description of changes:

When using cmake for building, make sure to include the cmake files and parameters that openharmony needs to ensure a successful build.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@richerfu richerfu requested a review from a team as a code owner June 5, 2024 06:07
@justsmth
Copy link
Contributor

justsmth commented Jun 5, 2024

Are there any tools (similar to cross-rs or cargo-xwin) that would allow us to test compilation to an OpenHarmony target in our CI?

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.67%. Comparing base (c358484) to head (45247cb).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
- Coverage   95.80%   92.67%   -3.13%     
==========================================
  Files          61       61              
  Lines        8143     8174      +31     
  Branches        0     8174    +8174     
==========================================
- Hits         7801     7575     -226     
- Misses        342      357      +15     
- Partials        0      242     +242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richerfu
Copy link
Contributor Author

richerfu commented Jun 5, 2024

Are there any tools (similar to cross-rs or cargo-xwin) that would allow us to test compilation to an OpenHarmony target in our CI?

No, in fact, there is currently no very suitable way to run code whose target architecture is openharmony, even rust or openharmony officially does not have it yet. When there is a suitable way, I will try to add the corresponding CI to support

@justsmth justsmth force-pushed the main branch 2 times, most recently from 6e5ae0f to 0e31dc3 Compare June 5, 2024 19:45
@justsmth justsmth merged commit 697167a into aws:main Jun 11, 2024
188 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants