Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing comma #445

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Missing comma #445

merged 2 commits into from
Jun 13, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Jun 13, 2024

Description of changes:

  • Missing comma in bindings "prelude".
    • The "prelude" is only used for the pre-generated bindings, which currently all have the comma.

Testing

  • Added CI job that exercises the bindings pregeneration logic

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner June 13, 2024 11:04
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.67%. Comparing base (c358484) to head (0fb5b49).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
- Coverage   95.80%   92.67%   -3.13%     
==========================================
  Files          61       61              
  Lines        8143     8174      +31     
  Branches        0     8174    +8174     
==========================================
- Hits         7801     7575     -226     
- Misses        342      357      +15     
- Partials        0      242     +242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth force-pushed the missing-comma branch 2 times, most recently from 7194f98 to 14afb83 Compare June 13, 2024 11:23
@justsmth justsmth merged commit 05b24c0 into aws:main Jun 13, 2024
189 checks passed
@justsmth justsmth deleted the missing-comma branch June 13, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants