Test more windows targets #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
==========================================
- Coverage 95.80% 92.83% -2.97%
==========================================
Files 61 62 +1
Lines 8143 8626 +483
Branches 0 8626 +8626
==========================================
+ Hits 7801 8008 +207
- Misses 342 362 +20
- Partials 0 256 +256 ☔ View full report in Codecov by Sentry. |
justsmth
force-pushed
the
more-windows-tests
branch
9 times, most recently
from
7022c42
to
0107064
Compare
justsmth
force-pushed
the
more-windows-tests
branch
3 times, most recently
from
37884d0
to
21cc839
Compare
rami3l
reviewed
Jul 1, 2024
justsmth
force-pushed
the
more-windows-tests
branch
from
21cc839
to
7a8297e
Compare
rami3l
reviewed
Jul 1, 2024
justsmth
force-pushed
the
more-windows-tests
branch
12 times, most recently
from
e37c74e
to
e41924b
Compare
justsmth
force-pushed
the
more-windows-tests
branch
6 times, most recently
from
4d39048
to
e62fc09
Compare
justsmth
force-pushed
the
more-windows-tests
branch
from
a39cb36
to
ff94714
Compare
|
It appears that the symbols provided by the assembly code are not getting prefixed: |
justsmth
force-pushed
the
more-windows-tests
branch
2 times, most recently
from
c297c02
to
fc8178a
Compare
I was missing the required include directory when building the assembly files. I think I'm closing in on the solution now. |
justsmth
force-pushed
the
more-windows-tests
branch
from
74568cf
to
f2dca65
Compare
justsmth
added a commit
to aws/aws-lc
that referenced
this pull request
Jul 15, 2024
### Issues: * Addresses: aws/aws-lc-rs#453 ### Description of changes: * When building for Windows/ARM64 with the "Visual Studio" generator (instead of Ninja) the "*.S" assembly source files for libraries are ignored. * This change provides a custom command to assemble the require objects files and adds them to the list of sources for the library. ### Call-outs: * See related aws-lc-rs PR: aws/aws-lc-rs#452 ### Testing * I've added CI tests to build for Windows using the "Visual Studio" generator. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
justsmth
force-pushed
the
more-windows-tests
branch
from
f2dca65
to
77346d8
Compare
justsmth
force-pushed
the
more-windows-tests
branch
2 times, most recently
from
506eb4e
to
433dbc2
Compare
justsmth
force-pushed
the
more-windows-tests
branch
from
433dbc2
to
eff8249
Compare
skmcgrail
approved these changes
Jul 15, 2024
samuel40791765
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
static_crtfor our build. See: Linkage error when cross-compiling foraarch64-pc-windows-msvc#453By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.