Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): armv7a and x86_64's ohos should set asm args #456

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

richerfu
Copy link
Contributor

@richerfu richerfu commented Jul 8, 2024

Issues:

So sorry that we must update cmake config for openharmony armv7a & x86_64.

Description of changes:

Before:
we will get some errors
image

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@richerfu richerfu requested a review from a team as a code owner July 8, 2024 12:28
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.83%. Comparing base (c358484) to head (a571c7a).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
- Coverage   95.80%   92.83%   -2.97%     
==========================================
  Files          61       62       +1     
  Lines        8143     8626     +483     
  Branches        0     8626    +8626     
==========================================
+ Hits         7801     8008     +207     
- Misses        342      362      +20     
- Partials        0      256     +256     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth requested a review from skmcgrail July 9, 2024 18:39
@justsmth justsmth merged commit b907119 into aws:main Jul 10, 2024
184 of 190 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants