Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI test for FreeBSD #477

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Add CI test for FreeBSD #477

merged 2 commits into from
Aug 6, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Aug 1, 2024

Issues:

Description of changes:

  • Add CI test for FreeBSD

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.83%. Comparing base (c358484) to head (81fda0a).
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   95.80%   92.83%   -2.97%     
==========================================
  Files          61       62       +1     
  Lines        8143     8626     +483     
  Branches        0     8626    +8626     
==========================================
+ Hits         7801     8008     +207     
- Misses        342      362      +20     
- Partials        0      256     +256     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth force-pushed the support-freebsd branch 5 times, most recently from c5327c3 to afc9e9b Compare August 1, 2024 13:53
@justsmth justsmth marked this pull request as ready for review August 2, 2024 12:46
@justsmth justsmth requested a review from a team as a code owner August 2, 2024 12:46
@justsmth justsmth mentioned this pull request Aug 2, 2024
@justsmth justsmth requested a review from skmcgrail August 2, 2024 13:09
usesh: true
copyback: false
prepare: |
pkg install -y git gmake bash sudo cmake-core llvm-devel-lite curl rust-bindgen-cli

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we expect bindgen's CLI to be stable through time? is there a way to pin it to current version?

Copy link
Contributor Author

@justsmth justsmth Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would hope it remains stable. If not, our policy will be to support the latest version of "bindgen" and advise consumers to re-install/upgrade to the latest.

@justsmth justsmth merged commit 8510fd1 into aws:main Aug 6, 2024
191 of 196 checks passed
@justsmth justsmth deleted the support-freebsd branch August 6, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants