Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim source paths for release binaries #478

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Aug 1, 2024

Issues:

Description of changes:

  • Strip the full source paths from "release" artifacts.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth force-pushed the strip-release-binary branch 2 times, most recently from 7c69d87 to 2edc4a6 Compare August 1, 2024 19:38
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (c358484) to head (76c2365).
Report is 51 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   95.80%   92.69%   -3.11%     
==========================================
  Files          61       63       +2     
  Lines        8143     8456     +313     
  Branches        0     8456    +8456     
==========================================
+ Hits         7801     7838      +37     
- Misses        342      361      +19     
- Partials        0      257     +257     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth marked this pull request as ready for review August 2, 2024 12:25
@justsmth justsmth requested a review from a team as a code owner August 2, 2024 12:25
@justsmth justsmth changed the title Strip source paths from release binaries Trim source paths for release binaries Aug 2, 2024
@justsmth justsmth mentioned this pull request Aug 2, 2024
@justsmth justsmth requested a review from skmcgrail August 2, 2024 13:09
@justsmth justsmth merged commit da66721 into aws:main Aug 12, 2024
184 of 196 checks passed
@justsmth justsmth deleted the strip-release-binary branch August 12, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants