-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KDF in Counter Mode and One-Step KDF API #482
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
==========================================
- Coverage 95.80% 92.58% -3.22%
==========================================
Files 61 66 +5
Lines 8143 8812 +669
Branches 0 8812 +8812
==========================================
+ Hits 7801 8159 +358
- Misses 342 396 +54
- Partials 0 257 +257 ☔ View full report in Codecov by Sentry. |
a86d4f4
to
8309141
Compare
}; | ||
} | ||
|
||
assert_get_unsupported_algorithm!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor nit, is there a better way to iterate over these with something like a macro?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it is possible to have a variadic macro, but given the subtle differences between each of the macro invocations below, a variadic mecro for this would likely be much less pleasant.
Description of changes:
Adds support for KDF in Counter Mode and One-Step Key Derivation functions from NIST SP 800-108 and NIST SP 800-56c respectively.
Currently the APIs are under
crate::unstable::kdf
due to not being able to support this with thefips
feature at this time.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.