Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RSA OAEP code into oaep module #487

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

skmcgrail
Copy link
Member

Description of changes:

Purely code organization change to make the PKCS1 v1.5 work simpler.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@skmcgrail skmcgrail requested a review from a team as a code owner August 5, 2024 19:05
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 91.46341% with 14 lines in your changes missing coverage. Please review.

Project coverage is 92.69%. Comparing base (c358484) to head (4b0b24b).
Report is 48 commits behind head on main.

Files Patch % Lines
aws-lc-rs/src/rsa/encryption/oaep.rs 91.46% 9 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #487      +/-   ##
==========================================
- Coverage   95.80%   92.69%   -3.11%     
==========================================
  Files          61       63       +2     
  Lines        8143     8456     +313     
  Branches        0     8456    +8456     
==========================================
+ Hits         7801     7838      +37     
- Misses        342      361      +19     
- Partials        0      257     +257     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

justsmth
justsmth previously approved these changes Aug 5, 2024
samuel40791765
samuel40791765 previously approved these changes Aug 5, 2024
@skmcgrail skmcgrail merged commit c8f806c into aws:main Aug 6, 2024
186 of 196 checks passed
@skmcgrail skmcgrail deleted the rsa-encryption-refactor branch August 6, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants