RSA PKCS1 v1.5 Encryption Support #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
==========================================
- Coverage 95.80% 92.71% -3.09%
==========================================
Files 61 64 +3
Lines 8143 8589 +446
Branches 0 8589 +8589
==========================================
+ Hits 7801 7963 +162
- Misses 342 365 +23
- Partials 0 261 +261 ☔ View full report in Codecov by Sentry. |
justsmth
reviewed
Aug 12, 2024
justsmth
approved these changes
Aug 15, 2024
samuel40791765
approved these changes
Aug 19, 2024
| let ciphertext = pkcs1_parsed_public | ||
| .encrypt(&message, &mut ciphertext) | ||
| .expect("encrypted"); | ||
|
|
There was a problem hiding this comment.
Nit: Would it be worth doing a assert_ne!(message, ciphertext); here, similar to what you're doing in rsa_test.rs?
There was a problem hiding this comment.
Will follow-up separately to clean-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
CryptoAlg-2596
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.