Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report bindgen version #494

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Report bindgen version #494

merged 1 commit into from
Aug 19, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Aug 13, 2024

Issues:

Addresses: #484

Description of changes:

When external bindgen is used, inspect the version number detected and provide guidance on how to upgrade.

Call-outs:

  • The output is sent to stderr and is only seen when the build fails.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner August 13, 2024 15:44
Inspect bindgen version
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (c358484) to head (3606c6c).
Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #494      +/-   ##
==========================================
- Coverage   95.80%   92.69%   -3.11%     
==========================================
  Files          61       63       +2     
  Lines        8143     8456     +313     
  Branches        0     8456    +8456     
==========================================
+ Hits         7801     7838      +37     
- Misses        342      361      +19     
- Partials        0      257     +257     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aws-lc-sys/builder/main.rs Show resolved Hide resolved
Comment on lines +585 to +593
eprintln!(
"bindgen-cli was used. Detected version was: {}.{}.{} \n\
If this is not the latest version, consider upgrading : \
`cargo install --force --locked bindgen-cli`\
\n\
See our User Guide for more information about bindgen:\
https://aws.github.io/aws-lc-rs/index.html",
major_version, minor_version, patch_version
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eprintln!(
"bindgen-cli was used. Detected version was: {}.{}.{} \n\
If this is not the latest version, consider upgrading : \
`cargo install --force --locked bindgen-cli`\
\n\
See our User Guide for more information about bindgen:\
https://aws.github.io/aws-lc-rs/index.html",
major_version, minor_version, patch_version
);
eprintln!(
"bindgen-cli was used. Detected version was: {major_version}.{minor_version}.{patch_version} \n\
If this is not the latest version, consider upgrading : \
`cargo install --force --locked bindgen-cli`\
\n\
See our User Guide for more information about bindgen:\
https://aws.github.io/aws-lc-rs/index.html"
);

@justsmth justsmth merged commit bddeebe into aws:main Aug 19, 2024
372 of 392 checks passed
@justsmth justsmth deleted the check-bindgen-version branch August 19, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants