Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup usage of unsafe blocks #499

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Cleanup usage of unsafe blocks #499

merged 1 commit into from
Aug 20, 2024

Conversation

justsmth
Copy link
Contributor

Description of changes:

  • Cleanup our usage of unsafe blocks.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner August 16, 2024 18:27
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 78.82353% with 18 lines in your changes missing coverage. Please review.

Project coverage is 92.59%. Comparing base (c358484) to head (c18b133).
Report is 55 commits behind head on main.

Files Patch % Lines
aws-lc-rs/src/ec.rs 77.14% 0 Missing and 8 partials ⚠️
aws-lc-rs/src/rsa/key.rs 72.22% 0 Missing and 5 partials ⚠️
aws-lc-rs/src/agreement.rs 81.81% 0 Missing and 2 partials ⚠️
aws-lc-rs/src/ec/key_pair.rs 66.66% 0 Missing and 2 partials ⚠️
aws-lc-rs/src/rsa/encoding.rs 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
- Coverage   95.80%   92.59%   -3.21%     
==========================================
  Files          61       66       +5     
  Lines        8143     8814     +671     
  Branches        0     8814    +8814     
==========================================
+ Hits         7801     8161     +360     
- Misses        342      396      +54     
- Partials        0      257     +257     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth merged commit 505c6bf into aws:main Aug 20, 2024
377 of 392 checks passed
@justsmth justsmth deleted the safer-unsafe branch August 20, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants