Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block::from can consume its argument #501

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

justsmth
Copy link
Contributor

Description of changes:

  • Avoid unnecessary copy - Block::from can consume its argument.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner August 16, 2024 20:28
@justsmth justsmth requested a review from skmcgrail August 16, 2024 20:35
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.58%. Comparing base (c358484) to head (55eca02).
Report is 55 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   95.80%   92.58%   -3.22%     
==========================================
  Files          61       66       +5     
  Lines        8143     8812     +669     
  Branches        0     8812    +8812     
==========================================
+ Hits         7801     8159     +358     
- Misses        342      396      +54     
- Partials        0      257     +257     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth merged commit c2612bf into aws:main Aug 19, 2024
187 of 196 checks passed
@justsmth justsmth deleted the Block-from branch August 19, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants