Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broader Ed25519 Key Format Support #506

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Conversation

skmcgrail
Copy link
Member

Description of changes:

  • Similar goal to Support for compressed and X.509 public key format #498
  • Support parsing of raw ED25519 public keys or X.509 SubjectPublicInfo when performing signature validation
  • Support for X.509 SubjectPublicInfo serialization for ED25519 PublicKey using AsDer trait.
  • Add support for the AsDer for PKCS#8 v1 and v2 for Ed25519KeyPair for consistency with our serialization trait design.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@skmcgrail skmcgrail requested a review from a team as a code owner August 19, 2024 18:00
@skmcgrail skmcgrail requested a review from justsmth August 19, 2024 18:00
@skmcgrail skmcgrail marked this pull request as draft August 19, 2024 18:01
@skmcgrail skmcgrail marked this pull request as ready for review August 19, 2024 18:02
@skmcgrail skmcgrail changed the title Ed25519 redux Broader Ed25519 Key Format Support Aug 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 89.88764% with 18 lines in your changes missing coverage. Please review.

Project coverage is 92.48%. Comparing base (c358484) to head (c3f2c45).
Report is 78 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/ed25519.rs 90.22% 6 Missing and 11 partials ⚠️
aws-lc-rs/src/ec/key_pair.rs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
- Coverage   95.80%   92.48%   -3.32%     
==========================================
  Files          61       67       +6     
  Lines        8143     9235    +1092     
  Branches        0     9235    +9235     
==========================================
+ Hits         7801     8541     +740     
- Misses        342      422      +80     
- Partials        0      272     +272     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aws-lc-rs/src/ed25519.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/ed25519.rs Outdated Show resolved Hide resolved
justsmth
justsmth previously approved these changes Aug 21, 2024
samuel40791765
samuel40791765 previously approved these changes Aug 21, 2024
@skmcgrail skmcgrail merged commit eda2f67 into aws:main Aug 23, 2024
187 of 196 checks passed
@skmcgrail skmcgrail deleted the ed25519-redux branch August 23, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants