-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broader Ed25519 Key Format Support #506
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
force-pushed
the
ed25519-redux
branch
from
August 19, 2024 18:01
34410e1
to
bd7d81b
Compare
skmcgrail
force-pushed
the
ed25519-redux
branch
from
August 19, 2024 18:06
bd7d81b
to
e92f10a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
- Coverage 95.80% 92.48% -3.32%
==========================================
Files 61 67 +6
Lines 8143 9235 +1092
Branches 0 9235 +9235
==========================================
+ Hits 7801 8541 +740
- Misses 342 422 +80
- Partials 0 272 +272 ☔ View full report in Codecov by Sentry. |
justsmth
reviewed
Aug 19, 2024
skmcgrail
force-pushed
the
ed25519-redux
branch
from
August 19, 2024 19:58
82a3b2b
to
7c7e5cc
Compare
justsmth
approved these changes
Aug 19, 2024
justsmth
previously approved these changes
Aug 21, 2024
samuel40791765
previously approved these changes
Aug 21, 2024
skmcgrail
dismissed stale reviews from justsmth and samuel40791765
via
August 22, 2024 23:28
0334223
skmcgrail
force-pushed
the
ed25519-redux
branch
from
August 22, 2024 23:28
bef4c25
to
0334223
Compare
skmcgrail
force-pushed
the
ed25519-redux
branch
from
August 22, 2024 23:34
0334223
to
c3f2c45
Compare
justsmth
approved these changes
Aug 22, 2024
samuel40791765
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.