Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
On macos, the
collect_build_src.sh
was not identifyingrefcount_lock.c
as a source file b/c our automation performs the final build using the (default) C11 standard. However,refcount_lock.c
is still needed for C99 builds, but it was not listed.Description of changes:
collect_build_src.sh
so that it will always include bothrefcount_lock.c
andrefcount_c11.c
(although only one of these will actually be useful to any specific build).AWS_LC_SYS_C_STD
to either99
or11
results in a successful build.cc_builder
source listing so thatrefcount_lock.c
is included.Testing:
cc_builder
source listings it produces match what's in this PR: https://github.com/aws/aws-lc-rs/actions/runs/10700676326By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.