Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FreeBSD version to 14.1 in cross compiling workflow #536

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

yonas
Copy link
Contributor

@yonas yonas commented Sep 25, 2024

The latest production release of FreeBSD is 14.1

Issues:

Resolves #535

Description of changes:

Update from 13.2 to 14.1

Testing:

Check that the cross.yaml build works for FreeBSD.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

The latest production release of FreeBSD is 14.1
@yonas yonas requested a review from a team as a code owner September 25, 2024 02:10
@justsmth
Copy link
Contributor

Maybe we should test FreeBSD w/ 12.4, 13.4 and 14.1? The action we use appears to support all three: https://github.com/vmactions/freebsd-vm/tree/main/conf

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (c358484) to head (850fa77).
Report is 80 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
- Coverage   95.80%   92.52%   -3.28%     
==========================================
  Files          61       67       +6     
  Lines        8143     9277    +1134     
  Branches        0     9277    +9277     
==========================================
+ Hits         7801     8584     +783     
- Misses        342      422      +80     
- Partials        0      271     +271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Test using all of the currently supported FreeBSD versions: 13.4 and 14.1.
@yonas
Copy link
Contributor Author

yonas commented Sep 25, 2024

@justsmth Thanks, I've updated to build against 13.4 and 14.1, since 12.4 is no longer supported by the FreeBSD Foundation.

Copy link
Contributor

@justsmth justsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@justsmth justsmth merged commit baccbed into aws:main Sep 25, 2024
207 of 214 checks passed
@yonas yonas deleted the patch-1 branch September 25, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the cross build workflow to use FreeBSD 14.1
4 participants