Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FIPS feature w/ old compilers #564

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Oct 10, 2024

Description of changes:

  • The use of -ffile-prefix-map within the aws-lc-fips-sys build scripts was causing build failures with older compilers. This change conditions the use of the flag on the detection of compiler support.

Call-outs:

  • For the FIPS build most, but not all, of the build environment source paths are being removed. Changes to the AWS-LC CMake scripts are likely needed to fully support this.

Testing:

  • Added a CI dimension to test older compilers with FIPS feature enabled.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (c358484) to head (d98a3b2).
Report is 96 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
- Coverage   95.80%   92.62%   -3.18%     
==========================================
  Files          61       67       +6     
  Lines        8143     9366    +1223     
  Branches        0     9366    +9366     
==========================================
+ Hits         7801     8675     +874     
- Misses        342      420      +78     
- Partials        0      271     +271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth force-pushed the fips-compile-flags branch 5 times, most recently from 53678ed to c57c33d Compare October 10, 2024 13:43
@justsmth justsmth marked this pull request as ready for review October 10, 2024 14:26
@justsmth justsmth requested a review from a team as a code owner October 10, 2024 14:26
@skmcgrail skmcgrail merged commit 0534592 into aws:main Oct 10, 2024
240 of 244 checks passed
@justsmth justsmth deleted the fips-compile-flags branch October 11, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants