Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bindgen-cli error handling #625

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Dec 9, 2024

Issues:

Addresses #624

Description of changes:

Improve error handling when invocation of bindgen-cli fails.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner December 9, 2024 15:59
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (c358484) to head (7fe17bb).
Report is 128 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
- Coverage   95.80%   92.80%   -3.00%     
==========================================
  Files          61       67       +6     
  Lines        8143     9858    +1715     
  Branches        0     9858    +9858     
==========================================
+ Hits         7801     9149    +1348     
- Misses        342      426      +84     
- Partials        0      283     +283     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth requested a review from skmcgrail December 9, 2024 16:12
@justsmth justsmth merged commit 0a697c5 into aws:main Dec 12, 2024
259 of 260 checks passed
@justsmth justsmth deleted the bindgen-error-handling branch December 12, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants