Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI cleanup #634

Merged
merged 1 commit into from
Dec 17, 2024
Merged

CI cleanup #634

merged 1 commit into from
Dec 17, 2024

Conversation

justsmth
Copy link
Contributor

Description of changes:

  • Cleanup of CI, removing no-longer-accurate comments.
  • More caution about using the -Wno-overriding-t-option option for the FIPS build.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (c358484) to head (12ff214).
Report is 137 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
- Coverage   95.80%   92.89%   -2.91%     
==========================================
  Files          61       67       +6     
  Lines        8143     9717    +1574     
  Branches        0     9717    +9717     
==========================================
+ Hits         7801     9027    +1226     
- Misses        342      402      +60     
- Partials        0      288     +288     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth marked this pull request as ready for review December 17, 2024 14:36
@justsmth justsmth requested a review from a team as a code owner December 17, 2024 14:36
@justsmth justsmth merged commit 14d2457 into aws:main Dec 17, 2024
253 of 259 checks passed
@justsmth justsmth deleted the ci-cleanup branch December 17, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants