Skip to content

Commit

Permalink
Quell static-analysis concern about div-by-0 (#1866)
Browse files Browse the repository at this point in the history
### Issues:
Addresses #1856

### Description of changes: 
Clarify pkcs8 logic so it doesn't trip up static analysis.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
  • Loading branch information
justsmth authored Sep 20, 2024
1 parent e7e48b1 commit 46394bd
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions crypto/pkcs8/pkcs8.c
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,11 @@ int pkcs12_key_gen(const char *pass, size_t pass_len, const uint8_t *salt,
for (size_t i = 0; i < S_len; i++) {
I[i] = salt[i % salt_len];
}
for (size_t i = 0; i < P_len; i++) {
I[i + S_len] = pass_raw[i % pass_raw_len];
// P_len would be 0 in this case, but static analyzers don't always see that
if(pass_raw_len > 0) {
for (size_t i = 0; i < P_len; i++) {
I[i + S_len] = pass_raw[i % pass_raw_len];
}
}

while (out_len != 0) {
Expand Down

0 comments on commit 46394bd

Please sign in to comment.