add integration test CI dimension for MariaDB #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel40791765
force-pushed
the
mariadb-ci
branch
from
ed5c438 to
b839874
Compare
samuel40791765
force-pushed
the
mariadb-ci
branch
11 times, most recently
from
2261da8 to
f9728e8
Compare
samuel40791765
force-pushed
the
mariadb-ci
branch
from
f9728e8 to
1c485d9
Compare
justsmth
reviewed
Jun 20, 2023
andrewhop
reviewed
Jun 20, 2023
Comment on lines
+65
to
+72
| - ivec); | ||
| - DES_set_key_unchecked(&keyblock.key1,&(des_keyschedule[(int)offset].ks1)); | ||
| - DES_set_key_unchecked(&keyblock.key2,&(des_keyschedule[(int)offset].ks2)); | ||
| - DES_set_key_unchecked(&keyblock.key3,&(des_keyschedule[(int)offset].ks3)); | ||
| + ivec.bytes); | ||
| + DES_set_key(&keyblock.key1,&(des_keyschedule[(int)offset].ks1)); | ||
| + DES_set_key(&keyblock.key2,&(des_keyschedule[(int)offset].ks2)); | ||
| + DES_set_key(&keyblock.key3,&(des_keyschedule[(int)offset].ks3)); |
There was a problem hiding this comment.
Did you consider adding a simple function that maps DES_set_key_unchecked -> DES_set_key? This isn't the only project to hit this issue.
There was a problem hiding this comment.
I took this patch directly from the work ottoke@ had been doing. But I can add it in a subsequent PR and remove this patch once we do so
...ci/integration/mariadb_patch/0004-WIP-Skip-test-that-is-disabled-when-using-OpenSSL-1..patch
Show resolved
Hide resolved
Comment on lines
+7
to
+8
| Disable the WolfSSL specific bug fix as it breaks AWS-LC builds with | ||
| errors like: |
There was a problem hiding this comment.
Why is the AWS-LC build enabling WolfSSL bug fixes?
There was a problem hiding this comment.
Sorry, I don't have a good answer to what MariaDB/WolfSSL was doing under the hood here :( If it helps, I looked into the files and it seems like the WolfSSL bug fix was being performed, regardless of what backend crypto was being used.
...ci/integration/mariadb_patch/0003-WIP-Use-replace_regex-in-mysql-test-run-to-make-SSL-.patch
Show resolved
Hide resolved
samuel40791765
force-pushed
the
mariadb-ci
branch
2 times, most recently
from
7b0cfb8 to
728fa17
Compare
justsmth
previously approved these changes
Jun 22, 2023
andrewhop
previously approved these changes
Jun 23, 2023
samuel40791765
force-pushed
the
mariadb-ci
branch
from
728fa17 to
82a4065
Compare
samuel40791765
force-pushed
the
mariadb-ci
branch
from
82a4065 to
ecd4238
Compare
andrewhop
approved these changes
Jun 23, 2023
justsmth
approved these changes
Jun 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
No Issue cut
Description of changes:
We've recently resolved missing symbols for MariaDB and are looking to add a CI dimension to ensure we don't break the build. Patches and flags necessary were taken from internal work on MariaDB.
Call-outs:
N/A
Testing:
New CI dimension
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.