Fix DISABLE_PERL=on builds for non-assembly optimized platforms #1068
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I noticed that when attempting to build aws-lc with
DISABLE_PERL=on
the logic is not 100% accurate on whether it should expect to find optimized assembly for a given architecture or not. If you attempt to build aws-lc on an architecture with no provided assembly, and don't setDISABLE_PERL=off
or setOPENSSL_NO_ASN=on
the build may fail with the following message:However there is logic in this check that looks to see if
$(ARCH) == generic
, and will otherwise not set theASSEMBLY_SOURCE
variable. There are instances such asriscv64
where the processor is detected, andARCH
is purposefully not set to the valuegeneric
. This causes the build to fail in this specific configuration combination outlined above, even if we don't have assembly source for that platform purposefully. This adds a status message to indicate if a pre-generated assembly directory is non-existent, and allows the compilation to move forward. Note that BoringSSL does not have this issue as they don't provide pre-generated assembly files.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.