Add back custom extension support for libssl #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhop
force-pushed
the
custom_extension
branch
from
6c71df1 to
f4c968c
Compare
skmcgrail
reviewed
Jun 26, 2023
skmcgrail
previously approved these changes
Jun 27, 2023
samuel40791765
approved these changes
Jun 28, 2023
skmcgrail
approved these changes
Jul 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses CryptoAlg-1875
Description of changes:
This reverts 0a3e07a and adds custom extension support back to AWS-LC which was originally added in google/boringssl@0950563.
Call-outs:
I had to update the 0-RTT test logic from e580e9d to handle the custom extensions.
Testing:
Unit and new integration tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.