Align OCSP behavior with OpenSSL for nginx #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
previously approved these changes
Jul 6, 2023
samuel40791765
force-pushed
the
ocsp-adjust
branch
from
45e136b to
075f0fb
Compare
andrewhop
reviewed
Jul 10, 2023
samuel40791765
force-pushed
the
ocsp-adjust
branch
from
075f0fb to
da67945
Compare
samuel40791765
force-pushed
the
ocsp-adjust
branch
from
110411b to
326e3c0
Compare
andrewhop
approved these changes
Jul 11, 2023
skmcgrail
approved these changes
Jul 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves
CryptoAlg-1849Description of changes:
Asides from the behavior fixed in #1074, there was some slight OCSP errors when building with nginx's OCSP stapling tests. There are still a couple of tests failing due to us missing multiple certs support, but this should resolve all other issues with us failing the test.
ocsp_find_signer_skstatic function was a bit too pedantic, so I relaxed it. It's possible for the OCSP Basic response to be missing a cert stack, so we shouldn't be throwing an error on the stack if that happens.OCSP_NOVERIFYandOCSP_TRUSTOTHERCall-outs:
N/A
Testing:
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.