Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable two "Visual Studio 17 2022" warnings #1087

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

justsmth
Copy link
Contributor

Issues:

N/A

Description of changes:

  • Disables two warnings generated when compiling with "Visual Studio 17 2022".
  • Build succeeds for both shared and static build on Windows/x86-64.

Call-outs:

N/A

Testing:

Tested on Windows Server 2019 EC2 instance:

\aws-lc\build> cmake -DBUILD_SHARED_LIBS=1 ..
-- Building for: Visual Studio 17 2022
-- The C compiler identification is MSVC 19.36.32535.0
...
repos\aws-lc\build> cmake --build .
MSBuild version 17.6.3+07e294721 for .NET Framework

  Checking Build System
  Building Custom Rule C:/Users/Administrator/repos/aws-lc/CMakeLists.txt
...

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth merged commit 84cf709 into aws:main Jul 10, 2023
@justsmth justsmth deleted the build-vs-2022 branch July 10, 2023 16:28
justsmth added a commit to justsmth/aws-lc that referenced this pull request Jul 11, 2023
@andrewhop andrewhop mentioned this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants