Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SHA3 digests with EC key types #1094

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Allow SHA3 digests with EC key types #1094

merged 3 commits into from
Jul 14, 2023

Conversation

skmcgrail
Copy link
Member

Description of changes:

While migrating to the DigestSign and DigestVerify APIs for aws-lc-rs I discovered that DigestSignInit and DigestVerifyInit fail when using SHA3 digest functions. It seems like these might have gotten missed when we implemented SHA3 / enabled the feature as "always on".

Call-outs:

This will need to be cherry-picked to fips-2022-11-02 branch for aws-lc-rs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@skmcgrail skmcgrail merged commit 1ed844a into aws:main Jul 14, 2023
@skmcgrail skmcgrail deleted the sha3 branch July 14, 2023 00:56
@skmcgrail skmcgrail restored the sha3 branch July 14, 2023 00:56
@skmcgrail skmcgrail mentioned this pull request Jul 14, 2023
skmcgrail added a commit to skmcgrail/aws-lc that referenced this pull request Jul 17, 2023
* Allow SHA3 digests with EC key types
* Regenerated crypto_test_data.cc

(cherry picked from commit 1ed844a)
skmcgrail added a commit to skmcgrail/aws-lc that referenced this pull request Jul 17, 2023
* Allow SHA3 digests with EC key types
* Regenerated crypto_test_data.cc

(cherry picked from commit 1ed844a)
skmcgrail added a commit to skmcgrail/aws-lc that referenced this pull request Jul 17, 2023
* Allow SHA3 digests with EC key types
* Regenerated crypto_test_data.cc

(cherry picked from commit 1ed844a)
skmcgrail added a commit that referenced this pull request Jul 17, 2023
@skmcgrail skmcgrail deleted the sha3 branch August 1, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants