Silence static analyser by validating pointer prior to function call #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebeid
previously approved these changes
Jul 19, 2023
samuel40791765
previously approved these changes
Jul 19, 2023
torben-hansen
dismissed stale reviews from nebeid and samuel40791765
via
88a64c6
nebeid
approved these changes
Jul 19, 2023
samuel40791765
approved these changes
Jul 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
V963870416
Description of changes:
Attempts to silence the static analyser...
EC_KEY_get0_public_keydoesn't validate the pointer argument and can de-referenceNULL. This is common for the getters. Avoid changing that behaviour and just fix-up the speed tool code instead using a non-owning pointer.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.