Fix DH_check() excessive time with oversized modulus #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
reviewed
Jul 20, 2023
samuel40791765
previously approved these changes
Jul 20, 2023
torben-hansen
previously approved these changes
Jul 20, 2023
justsmth
previously approved these changes
Jul 20, 2023
samuel40791765
previously approved these changes
Jul 20, 2023
skmcgrail
dismissed stale reviews from samuel40791765, justsmth, and torben-hansen
via
4bef23e
justsmth
approved these changes
Jul 21, 2023
samuel40791765
approved these changes
Jul 21, 2023
Merged
skmcgrail
added a commit
to skmcgrail/aws-lc
that referenced
this pull request
Aug 1, 2023
(cherry picked from commit 9545d9d)
skmcgrail
added a commit
to skmcgrail/aws-lc
that referenced
this pull request
Aug 1, 2023
(cherry picked from commit 9545d9d)
skmcgrail
added a commit
to skmcgrail/aws-lc
that referenced
this pull request
Aug 1, 2023
(cherry picked from commit 9545d9d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Addresses CVE-2023-3446 which was low severity issue reported to OpenSSL on July 13th 2023. (See bulletin.
Excessively long DH keys can be slow to check which may lead to denial of service.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.