Silence static analyser with additional checks #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel40791765
force-pushed
the
small-fixes
branch
from
0ecad2e to
c740172
Compare
skmcgrail
approved these changes
Jul 31, 2023
nebeid
approved these changes
Jul 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves
V973158980Description of changes:
Our static analyser caught some places where we weren't checking the return type before the value was used. Only the mssing check in
ssl_set_certwas detected. The analyser didn't complain aboutcert_set_chain_and_key, but I added a comment there for clarification.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.