Implementation passive entropy #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhop
reviewed
Aug 1, 2023
torben-hansen
force-pushed
the
implementation_passive_entropy
branch
from
6a83064 to
37771cb
Compare
skmcgrail
previously approved these changes
Aug 2, 2023
andrewhop
reviewed
Aug 3, 2023
torben-hansen
force-pushed
the
implementation_passive_entropy
branch
from
1c0a4f6 to
045babe
Compare
andrewhop
previously approved these changes
Aug 4, 2023
skmcgrail
previously approved these changes
Aug 4, 2023
andrewhop
previously approved these changes
Aug 4, 2023
…st files. Try to work around that...
…o the test files. Try to work around that..." This reverts commit fb382b8.
andrewhop
approved these changes
Aug 4, 2023
skmcgrail
approved these changes
Aug 7, 2023
torben-hansen
added a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 18, 2023
skmcgrail
pushed a commit
that referenced
this pull request
Sep 20, 2023
* Make PRNG model slightly more readable (#1079) The way the PRNG model is written looks more complicated than what is actually needed. Attempt to re-write it. This also makes it slightly easier to amend with future potential changes. * Remove CRNGT (#1112) CRNGT is not a requirement for FIPS 140-3. FIPS 140-2 Section 4.9.2 required the execution of the Continuous Randomness Number Generation Test (CRNGT). However, this requirement is not present in FIPS 140-3. In addition, later stages of FIPS 140-2 this test was not mandatory in all cases either (cf. FIPS 140-2 IG 9.8). Executing this test requires maintaining state, which inevitably introduces complexity. Given CRNGT is redundant with respect to compliance and really provides zero practical value (see, again, FIPS 140-2 IG 9.8), we axe it. * Abstract fips entropy functions (#1113) Abstract getting data from the configured entropy source of FIPS. Atm, the configured source is hard-coded in multiple workflows. This allows adding another source more easily. In addition, add some machinery to configure another source of build-time using the new define FIPS_ENTROPY_SOURCE_JITTER_CPU. * Implementation passive entropy (#1125) * Use passive entropy source method by default for FIPS build mode (#1188) Enables passive entropy method by default. In addition, adds a build-time config that can modify (at build-time) the entropy source method to CPU Jitter. * Kick CI bots * Kick CI bots, again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
CryptoAlg-1953
Description of changes:
Implement passive entropy FIPS source.
Call-outs:
Currently, to compile with this source use
-DUSE_FIPS_ENTROPY_SOURCE_PASSIVE. In the future this will be swapped over to be the default and the Jitter CPU source will be an option that must be enabled at build-time.This PR adds back the state parameter to
rand_get_seed- it makes more sense since the state might be needed and there is no need to query the thread list twice...Testing:
Adds an additional target to CI that uses the special build-option
-DUSE_FIPS_ENTROPY_SOURCE_PASSIVEand pass over onerun_teststarget.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.