Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back SSL_use_certificate_chain_file #1312

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

samuel40791765
Copy link
Contributor

Issues:

Addresses CryptoAlg-2165

Description of changes:

Librelp consumes this so we have to add it back. I translated the underlying function to C++ while I was at it. The function (like it's OpenSSL version) has some SSL_CTX and SSL specific logic, so there needs to be a way to differentiate.

Call-outs:

N/A

Testing:

New test for SSL_use_certificate_chain_file and SSL_CTX_use_certificate_chain_file.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@samuel40791765 samuel40791765 requested a review from a team as a code owner November 16, 2023 21:09
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (b15b9d3) 77.96% compared to head (ca98931) 76.45%.
Report is 16 commits behind head on main.

Files Patch % Lines
ssl/ssl_file.cc 77.77% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
- Coverage   77.96%   76.45%   -1.51%     
==========================================
  Files         530      421     -109     
  Lines      101077    70989   -30088     
==========================================
- Hits        78805    54278   -24527     
+ Misses      22272    16711    -5561     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuel40791765 samuel40791765 force-pushed the ssl-cert-file branch 3 times, most recently from d7f85e7 to 3cc25c4 Compare November 17, 2023 03:26
ssl/CMakeLists.txt Show resolved Hide resolved
ssl/ssl_file.cc Outdated Show resolved Hide resolved
ssl/ssl_file.cc Show resolved Hide resolved
ssl/ssl_test.cc Outdated Show resolved Hide resolved
@samuel40791765 samuel40791765 merged commit c97aee2 into aws:main Nov 27, 2023
20 checks passed
@samuel40791765 samuel40791765 deleted the ssl-cert-file branch November 27, 2023 19:05
@justsmth justsmth mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants