-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement AES-CCM #1373
Merged
Merged
Implement AES-CCM #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1373 +/- ##
==========================================
- Coverage 76.84% 76.82% -0.02%
==========================================
Files 424 424
Lines 71392 71500 +108
==========================================
+ Hits 54859 54933 +74
- Misses 16533 16567 +34 ☔ View full report in Codecov by Sentry. |
geedo0
force-pushed
the
ccm
branch
29 times, most recently
from
December 29, 2023 16:38
637c144
to
3f42fc7
Compare
geedo0
force-pushed
the
ccm
branch
6 times, most recently
from
December 29, 2023 18:40
d79d7e1
to
b60dba4
Compare
This exposes the AES-CCM block cipher algorithm via the EVP_CIPHER API. Currently we only support a limited set of AES-CCM modes via the EVP_AEAD interface for the Bluetooth, Bluetooth-8, and Matter wireless protocols. This PR introduces support for all AES key sizes (128, 192, and 256) as well as the ability to configure arbitrary AES-CCM modes via the M and L parameters.
WillChilds-Klein
previously approved these changes
Jan 9, 2024
WillChilds-Klein
previously approved these changes
Jan 11, 2024
torben-hansen
approved these changes
Jan 12, 2024
WillChilds-Klein
approved these changes
Jan 12, 2024
dougch
pushed a commit
to dougch/aws-lc
that referenced
this pull request
Jan 30, 2024
This exposes the AES-CCM block cipher algorithm via the EVP_CIPHER API. Currently we only support a limited set of AES-CCM modes via the EVP_AEAD interface for the Bluetooth, Bluetooth-8, and Matter wireless protocols. This PR introduces support for all AES key sizes (128, 192, and 256) as well as the ability to configure arbitrary AES-CCM modes via the M and L parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves: CryptoAlg-2085
Description of changes:
Describe AWS-LC’s current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.
This exposes the AES-CCM block cipher algorithm via the EVP_CIPHER API. Currently we only support a limited set of AES-CCM modes via the EVP_AEAD interface for the Bluetooth, Bluetooth-8, and Matter wireless protocols. This PR introduces support for all AES key sizes (128, 192, and 256) as well as the ability to configure arbitrary AES-CCM modes via the M and L parameters.
Call-outs:
in
andout
parameters going into EVP_Cipher_Update is very important. The unit tests have been updated to ensure that non-NULL pointers are passed in regardless of whether or not the length is 0.Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
convert_wycheproof.go
and run through the test runner developed for ChaCha20-Poly1305.aws-lc-ci-ec2-test-framework
which appears universal to all active PRs.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.