Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base ec2 test framework #1395

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Update base ec2 test framework #1395

merged 3 commits into from
Jan 12, 2024

Conversation

andrewhop
Copy link
Contributor

@andrewhop andrewhop commented Jan 11, 2024

Description of changes:

  1. Use latest ARM Ubuntu image
  2. Tag instances with a name that links back to the requesting PR to make tracking leaks easier
  3. Add a final log message to see if that shows up in CloudWatch logs

Call-outs:

I think the older AMI just happened to have an SSM agent that couldn't handle the large output of the single "command" and crashed with document process failed unexpectedly: document worker timed out I haven't been able to reproduce that issue with this newer AMI.

Verified in the ec2 console the new name shows up {Key="Name",Value="ec2-test-pr/1395"}

Testing:

Manually tested with SSM run command in my account, lets see what happens here.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@andrewhop andrewhop requested a review from a team as a code owner January 11, 2024 03:17
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6e201b) 76.81% compared to head (c36e5bf) 76.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1395      +/-   ##
==========================================
- Coverage   76.81%   76.80%   -0.01%     
==========================================
  Files         424      424              
  Lines       71338    71338              
==========================================
- Hits        54798    54793       -5     
- Misses      16540    16545       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewhop andrewhop enabled auto-merge (squash) January 11, 2024 05:44
@andrewhop andrewhop merged commit 82ff6a0 into aws:main Jan 12, 2024
35 of 36 checks passed
dougch pushed a commit to dougch/aws-lc that referenced this pull request Jan 30, 2024
* Update EC2 AMI for Graviton 3 to latest Ubuntu 22.04 image, improve naming convention for hosts, and add logging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants