Turn off flaky MariaDB test main.ssl_crl #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
==========================================
- Coverage 76.81% 76.80% -0.02%
==========================================
Files 424 424
Lines 71338 71338
==========================================
- Hits 54798 54790 -8
- Misses 16540 16548 +8 ☔ View full report in Codecov by Sentry. |
WillChilds-Klein
approved these changes
Jan 11, 2024
justsmth
approved these changes
Jan 11, 2024
dougch
pushed a commit
to dougch/aws-lc
that referenced
this pull request
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses P112867839
Description of changes:
This test fails 80% of the time. It could have something to do with exact error code mismatch between OpenSSL and AWS-LC. Turning it off for now and tracking the fix in P112867839.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.