Use system allocator for thread-local values

[justsmth]

Issues:

P111627750

Description of changes:

• Depending on order destructors are called during process exit, custom allocators might no longer be available.
• This commit uses the system allocator for all of our thread local values.

Call-outs:

• Thread locals relating to error were already using the system allocator.
• Likewise, the system allocator is used for our pthread logic managing thread locals.

Testing:

• Tested locally.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

[WillChilds-Klein]

Depending on order destructors are called during process exit, custom allocators might no longer be available.

do we know which dtor invalidates the OpenSSL allocator? i'm wondering if, knowing which dtor needs to be called last, there's some way to enforce that that dtor is always called last.

[justsmth]

Depending on order destructors are called during process exit, custom allocators might no longer be available.

do we know which dtor invalidates the OpenSSL allocator? i'm wondering if, knowing which dtor needs to be called last, there's some way to enforce that that dtor is always called last.

The concern is for consumers that are using CRYPTO_set_mem_functions to inject a custom allocator. At process exit, it's possible that our destructors are being invoked after the consumer's custom allocator (whatever that may be) has been destructed.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (82ff6a0) 76.81% compared to head (e78d97d) 76.86%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1397      +/-   ##
==========================================
+ Coverage   76.81%   76.86%   +0.05%     
==========================================
  Files         424      424              
  Lines       71338    71339       +1     
==========================================
+ Hits        54795    54835      +40     
+ Misses      16543    16504      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.