Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional EVP_AEAD_CTX / TLS Transfer Serialization Tests #1407

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Jan 17, 2024

Addresses V1177698156, V1177861396, V1142772501

Description of changes:

Increase test coverage for the TLS transfer feature.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@skmcgrail skmcgrail requested a review from a team as a code owner January 17, 2024 19:06
@skmcgrail skmcgrail changed the title Transfer serde Additional EVP_AEAD_CTX Serialization Tests Jan 17, 2024
@skmcgrail skmcgrail changed the title Additional EVP_AEAD_CTX Serialization Tests Additional EVP_AEAD_CTX / TLS Transfer Serialization Tests Jan 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5c35810) 76.88% compared to head (a84d1fa) 76.85%.

Files Patch % Lines
crypto/fipsmodule/cipher/aead.c 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1407      +/-   ##
==========================================
- Coverage   76.88%   76.85%   -0.03%     
==========================================
  Files         425      425              
  Lines       71527    71535       +8     
==========================================
- Hits        54991    54978      -13     
- Misses      16536    16557      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@torben-hansen torben-hansen self-requested a review January 24, 2024 15:45
torben-hansen
torben-hansen previously approved these changes Jan 24, 2024
crypto/cipher_extra/aead_test.cc Show resolved Hide resolved
crypto/fipsmodule/cipher/internal.h Show resolved Hide resolved
ssl/ssl_test.cc Outdated Show resolved Hide resolved
crypto/cipher_extra/aead_test.cc Show resolved Hide resolved
torben-hansen
torben-hansen previously approved these changes Feb 14, 2024
andrewhop
andrewhop previously approved these changes Feb 14, 2024
@skmcgrail skmcgrail merged commit ddc449d into aws:main Feb 15, 2024
38 checks passed
@skmcgrail skmcgrail deleted the transfer-serde branch February 15, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants