Speed up CodeBuild CI #1426
Speed up CodeBuild CI #1426
Conversation
1. Split OpenSSH into two jobs, one for main branch, and another for 8.9 2. Use RelWithDebInfo build for MySQL 3. Force MySQL to use double the number of jobs to run the tests 4. Update ARM fuzzer to run for a shorter period of time
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1426 +/- ##
==========================================
- Coverage 76.87% 76.84% -0.04%
==========================================
Files 425 425
Lines 71527 71527
==========================================
- Hits 54985 54962 -23
- Misses 16542 16565 +23 ☔ View full report in Codecov by Sentry. |
| if [ "$OPENSSH_BRANCH" != "master" ]; then | ||
| checkout_openssh_branch "$OPENSSH_BRANCH" | ||
| fi |
There was a problem hiding this comment.
can you do this checkout unconditionally? if OpenSSH ever changes the name of their default branch, this might break.
There was a problem hiding this comment.
Git was complaining about a 'master' branch already existing, I couldn't find a nice option to checkout if it doesn't already exist so i went with this.
There was a problem hiding this comment.
hm, maybe you could do something like
if [ "$OPENSSH_BRANCH != $(git branch --show-current) ]; then
checkout_openssh_branch "$OPENSSH_BRANCH
fi
| env: | ||
| type: ARM_CONTAINER | ||
| privileged-mode: false | ||
| compute-type: BUILD_GENERAL1_LARGE |
There was a problem hiding this comment.
Do we need BUILD_GENERAL1_LARGE here considering we use BUILD_GENERAL1_SMALL for x86?
Description of changes:
Call-outs:
The majority of the MySQL CI time is spent building (~50 minutes) and then running the tests (22 minutes). The build already uses all CPU cores, but the tests seem not take full advantage with the default
parallel=autowhich just uses 1 test per core (orange is CPU usage %, blue is memory usage %):Testing:
Locally and in this CI.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.