Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BIOTest.InvokeConnectCallback test. #1433

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

PiotrSikora
Copy link
Contributor

@PiotrSikora PiotrSikora commented Feb 5, 2024

Description of changes:

Fix BIOTest.InvokeConnectCallback test.

Previously, the test tried to connect to localhost on port 8080, which
is a frequently used alternative HTTP port, and it failed if there was
anything listening on that port.

Call-outs:

N/A

Testing:

./crypto/crypto_test --gtest_filter="BIOTest.InvokeConnectCallback"

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth
Copy link
Contributor

justsmth commented Feb 5, 2024

I supposed it doesn't matter as long as the connection fails, but I would prefer the test connecting to a non-privileged port (>= 1024). Something arbitrary and not in common use (5325 or 9723?).

Previously, the test tried to connect to localhost on port 8080, which
is a frequently used alternative HTTP port, and it failed if there was
anything listening on that port.

Signed-off-by: Piotr Sikora <piotr@aviatrix.com>
@PiotrSikora
Copy link
Contributor Author

PiotrSikora commented Feb 6, 2024

I supposed it doesn't matter as long as the connection fails, but I would prefer the test connecting to a non-privileged port (>= 1024). Something arbitrary and not in common use (5325 or 9723?).

I intentionally selected privileged port, since it's less likely that there will be something random listening on it, but sure, changed to port 5325.

@PiotrSikora
Copy link
Contributor Author

Could you re-kick AWS CodeBuild BuildBatch us-west-2 (aws-lc-ci-integration) (assuming it's a flaky test and not a real failure - there is no public access to the CI output)? Thanks!

@justsmth justsmth enabled auto-merge (squash) February 8, 2024 21:22
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af5fe84) 76.85% compared to head (9884e23) 76.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1433      +/-   ##
==========================================
- Coverage   76.85%   76.84%   -0.01%     
==========================================
  Files         425      425              
  Lines       71527    71527              
==========================================
- Hits        54974    54968       -6     
- Misses      16553    16559       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth merged commit b614bbf into aws:main Feb 8, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants